Skip to content

Fix photo naming expression returning NULL #4671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xkello wants to merge 1 commit into from
Open

Fix photo naming expression returning NULL #4671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/attributes/attributecontroller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1715,6 +1715,13 @@ void AttributeController::renamePhotos()

InputUtils::sanitizePath( newName );

if ( newName.trimmed().isEmpty() )
{
CoreUtils::log( QStringLiteral( "Photo name format" ), QStringLiteral( "Expression for %1:%2 evaluated to an empty or NULL name, keeping the original file name" ).arg( mFeatureLayerPair.layer()->name(), field.name() ) );

@Withalion Withalion Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to log Layer, feature and then field, to help support debug this issue.

++formItemsIterator;
continue;
}

const QFileInfo fi( src );
newName = QStringLiteral( "%1.%2" ).arg( newName, fi.completeSuffix() );

Expand Down
Loading