Add check so unlink button won't show on a new feature - #4685
Open
xkello wants to merge 3 commits into
Open
Conversation
Coverage Report for CI Build 34199761084Coverage decreased (-0.07%) to 59.55%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions11 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
uclaros
reviewed
Aug 28, 2026
Withalion
reviewed
Sep 4, 2026
Withalion
left a comment
Withalion
left a comment
Collaborator
There was a problem hiding this comment.
And also the comment from Stefanos
📦 Build Artifacts Ready
|
Withalion
approved these changes
Sep 7, 2026
Withalion
left a comment
Withalion
left a comment
Collaborator
There was a problem hiding this comment.
Please rebase on current master, so iOS build will pass
…k-button-on-unsaved-feature
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Unlink photo" option in the photo delete drawer was showing even when the feature hadn't been saved yet. Since an unsaved feature has no persisted attachment relation to unlink from, the option didn't make sense there.
Fixes: #4542
What changed
Exposed a new
isNewFeatureproperty onAttributeController(reusing the existingfeatureLayerPairChangedsignal so it stays reactive).MMFormPhotoEditorpasses this down asfeatureStatetoMMRemovePhotoDialog, which now hides the "Unlink photo" button whenfeatureState === "add".Behaviour
On a new, unsaved feature, the delete photo drawer now only shows "Delete photo". On an existing, saved feature, both "Delete photo" and "Unlink photo" still show as before.
Desktop:
Android: