Add condition so readOnly child cannot be added from parent - #4688
Open
xkello wants to merge 1 commit into
Open
Conversation
Coverage Report for CI Build 33178870626Coverage decreased (-0.04%) to 59.55%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions7 previously-covered lines in 1 file lost coverage.
Coverage Stats
馃挍 - Coveralls |
馃摝 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "add" button for relation-linked child features (photo gallery tiles and relation bubbles) was shown based only on the user's project role, without checking whether the underlying child layer itself was read-only. This allowed users to attempt adding features to layers that were explicitly configured as read-only in the QGIS project.
Fixes: #4640
What changed
Extended the visibility condition for the add button in
MMFormGalleryEditor.qmland the add relation button inMMFormRelationEditor.qmlto also checkrmodel.layer.readOnly, so the add button is hidden whenever the child layer is marked read-only, regardless of project role.Behavior
When the child layer is read-only, the add button is hidden and only existing linked child features remain visible. When the child layer is editable, the add button is shown as before (subject to the existing project role check). See attached screenshots for both editors, each with a read-only and non-read-only comparison alongside the corresponding QGIS layer settings.
Linked feature list - child layer
Photo gallery - child layer