Observation callsign changes for GPSRO

ci/build-and-test

@@ -24,8 +24,8 @@ HERE="$(cd "$(dirname "$0")" && pwd)"
 THIS="$(basename "$0")"
 NPROC=${NPROC:-$(nproc)}
 WORKD="$(mktemp -d "${THIS}-XXXXXX" -t)"
-GENERATOR=Unix\ Makefiles
-if command -v ninja &>/dev/null; then GENERATOR=Ninja; fi
+GENERATOR='Unix Makefiles'
+# if command -v ninja &>/dev/null; then GENERATOR=Ninja; fi
 BASE="${HERE%/*}"
 TESTDIR="${BASE##*/}"
 export OMPI_ALLOW_RUN_AS_ROOT=1

src/opsinputs/GnssroStationIDMetOffice.cc

@@ -37,6 +37,7 @@ static ObsFunctionMaker<GnssroStationIDMetOffice>
 GnssroStationIDMetOffice::GnssroStationIDMetOffice(const eckit::LocalConfiguration & conf)
   : invars_() {
   invars_ += Variable("MetaData/satelliteIdentifier");
+  invars_ += Variable("MetaData/qualityFlags");
 }
 
 // -----------------------------------------------------------------------------
@@ -55,6 +56,20 @@ void GnssroStationIDMetOffice::compute(const ObsFilterData & in,
   std::vector<int> satid;
   in.get(Variable("MetaData/satelliteIdentifier"), satid);
 
+  const int missing = util::missingValue<int>();
+  std::vector<int> qualityFlags;
+  in.get(Variable("MetaData/qualityFlags"), qualityFlags);
+  std::vector<int> isRising(nlocs, 2);  // setting = 0, rising = 1, unknown = 2
+  for (size_t i = 0; i < nlocs; ++i) {
+    if (qualityFlags[i] == missing) {
+      isRising[i] = 2;
+    } else if ((qualityFlags[i] & (1 << 13)) != 0) {
+      isRising[i] = 1;
+    } else {
+      isRising[i] = 0;
+    }
+  }
+
   // Get the record number of each profile
   std::vector<size_t> recordNumbers = out.space().recidx_all_recnums();
   oops::Log::debug() << "Unique record numbers" << std::endl;
@@ -69,7 +84,8 @@ void GnssroStationIDMetOffice::compute(const ObsFilterData & in,
     for (size_t jobs : obsNumbers) {
       out[0][jobs] = stringFormat(satid[jobs], 4) +
                      stringFormat(iProfile, 5) +
-                     stringFormat(jobs, 7);
+                     stringFormat(jobs, 6) +
+                     stringFormat(isRising[jobs], 1);
     }
   }
 }

test/generate_unittest_netcdfs.py

@@ -393,6 +393,9 @@ def output_2d_simulated_var_to_netcdf(var_name, file_name, with_bias=False, with
         var = f.createVariable('MetaData/satelliteIdentifier', 'i', ('Location',))
         var[:] = [3, 3, 5, 720]
 
+    var = f.createVariable('MetaData/qualityFlags', 'i', ('Location',))
+    var[:] = [8192, 0, 0, 0]
+
     # Create Variables
     var = f.createVariable('ObsValue/' + var_name, 'f', ('Location', 'Channel'))
     var[:, :] = [[1.1, 2.1, 3.1],
@@ -852,7 +855,8 @@ def copy_var_to_var(Group, invarname, outvarname, filename):
                                   'ObsValue/bendingAngle',
                                   'ObsError/bendingAngle'],
                                  [],
-                                 ['MetaData/satelliteIdentifier'],
+                                 ['MetaData/satelliteIdentifier',
+                                  'MetaData/qualityFlags'],
                                  'testinput/varobs_globalnamelist_gnssro.nc4')
 
     # Sonde

test/testinput/071_VarField_bendingangle.yaml

@@ -67,9 +67,9 @@ observations:
         time:     ["-3540.00000", "-3540.00000",
                    "-3480.00000", "-3480.00000", 
                    "-3360.00000", "-3360.00000"]
-        Callsign: ["0003000000000000", "0003000000000000",
-                   "0003000010000001", "0003000010000001",
-                   "0720000030000003", "0720000030000003"]
+        Callsign: ["0003000000000001", "0003000000000001",
+                   "0003000010000010", "0003000010000010",
+                   "0720000030000030", "0720000030000030"]
     HofX: ObsValue # just a placeholder -- not used, but needed to force calls to postFilter.
     benchmarkFlag: 1000 # just to keep the ObsFilters test happy
     flaggedBenchmark: 0