Fix duplicate heterogeneous chemistry reactions in UKCA StratTrop and CRI-Strat2#32
Draft
Luke Abraham (theabro) wants to merge 8 commits intoMetOffice:mainfrom
Draft
Fix duplicate heterogeneous chemistry reactions in UKCA StratTrop and CRI-Strat2#32Luke Abraham (theabro) wants to merge 8 commits intoMetOffice:mainfrom
Luke Abraham (theabro) wants to merge 8 commits intoMetOffice:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: James Bruten (@james-bruten-mo)
Within UKCA, N2O5 hydrolysis
N2O5 + H2O --> HONO2 + HONO2
is actually covered by 2 separate reactions, H04 and B85. There is actually considerable overlap of these reactions in the troposphere, leading to overcounting.
A fix is to ensure, using the tropospheric mask, that only H04 works in the stratosphere and B85 only works in the troposphere. This is controlled by a temporary logical,
l_fix_ukca_n2o5_h2o.This issue was originally identified by Dr Yao Ge (@yg460-cam) in Cambridge, and she provided the original UKCA code changes at UM13.9.
het_rxn_diffs.pdf shows comparisons between two simulations performed by Yao at UM13.9, highlightning the improvement given by this change (top) compared to the default behaviour (bottom).
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
Testing
stem suites
acceptable (eg. kgo changes)
tests, unit tests, etc.)
Testing was performed in the UKCA short testing suite:
This tests StratTrop and CRI-Strat2 with rigorous tests.
UMDP3 was checked with rose-stem.
trac.log
Test Suite Results - ukca - um14.1_hetchem_fixes/run1
Suite Information
Task Information
✅ succeeded tasks - 2
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review