refactor(keyring-snap-bridge)!: remove SnapKeyringV1 inheritance#584
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5e18a2b. Configure here.
SnapKeyringV1 inheritanceSnapKeyringV1 inheritance
hmalik88
reviewed
Jul 6, 2026
hmalik88
approved these changes
Jul 6, 2026
hmalik88
left a comment
Contributor
There was a problem hiding this comment.
Approving with the caveat that we don't merge until we test integration against the various preview builds we have up (sol, core, this)
Contributor
Author
|
Was able to create account and the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Removing inheritance so we the remaining v1 usage are explicit, since
SnapKeyring(v2) was implicitly exposing v1 methods, it made it pretty difficult to sunset v1 completely.Note
High Risk
Breaking public API and behavior split across account creation, signing, and snap messages in security-sensitive keyring code; incorrect v1/v2 routing could break snaps or block v2-only accounts.
Overview
Breaking: v2
SnapKeyringno longer extendsSnapKeyringV1. V1 behavior is exposed only via an optional.v1getter (set when the snap manifest has noendowment:keyringcapabilities;undefinedfor v2-only snaps).The per-snap v2 class now owns its registry and v2
KeyringInternalSnapClient, and ondeserializemay compose aSnapKeyringV1that shares the same registry.createAccounts/submitRequestroute to v1 or the v2 client depending on snap version (including the v1{ options }wrapper vs flat v2 options).The top-level
SnapKeyringcoordinator routes legacy v1 entry points (messages, signing, user ops, etc.) throughgetKeyringV1Forand throws clear errors when the target snap is v2-only.setSelectedAccountsuseskeyring.v1?.so v2 snaps are skipped.SnapKeyringV1gains optional sharedregistry, publicbindSnapId, andcreateAccountsfor v1 RPC. Changelog and tests document the API shift and v1/v2 routing.Reviewed by Cursor Bugbot for commit 693e6f3. Bugbot is set up for automated code reviews on this repo. Configure here.