release: 117.0.0#587
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4095a9b546
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The changelog check failed because keyring-eth-ledger-bridge and keyring-eth-trezor both bump the @metamask/hw-wallet-sdk runtime dependency from ^0.9.0 to ^0.10.0 in this release, but their CHANGELOG.md entries only referenced the prior bump (PR #576) and not this PR. Co-authored-by: Cursor <cursoragent@cursor.com>
ccharly
reviewed
Jul 6, 2026
ccharly
left a comment
Contributor
There was a problem hiding this comment.
Sorry, looks like the changelogs have still some issues, can you use those suggestions to clean everything up?
Co-authored-by: Charly Chevalier <charlyy.chevalier@gmail.com>
Contributor
|
I took over the release to release other packages too! (required for the last bit of rework around Snap keyring v2) |
ccharly
reviewed
Jul 6, 2026
gantunesr
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several MetaMask packages, primarily to bump versions and align dependencies, especially around the
@metamask/hw-wallet-sdkpackage. It also includes changelog updates and minor fixes to changelog formatting and references.Version and Dependency Updates:
@metamask/hw-wallet-sdkto version0.10.0and updated its dependency in both@metamask/eth-ledger-bridge-keyringand@metamask/eth-trezor-keyringto^0.10.0. [1] [2] [3]117.0.0inpackage.json.@metamask/eth-ledger-bridge-keyringto12.3.0and@metamask/eth-trezor-keyringto10.2.0. [1] [2]Changelog and Documentation Improvements:
@metamask/hw-wallet-sdk@0.10.0, including build/tooling improvements and new features, and updated changelog comparison links. [1] [2]@metamask/eth-ledger-bridge-keyring@12.3.0and@metamask/eth-trezor-keyring@10.2.0and fixed changelog PR grouping and references. [1] [2] [3] [4] [5] [6]Note
Medium Risk
Breaking
@metamask/eth-snap-keyring@23.0.0inheritance change affects snap integrators; bundled hardware-wallet error and typed-data behavior changes touch signing flows but this PR is primarily version/changelog alignment.Overview
Monorepo release 117.0.0 — bumps the root version and publishes coordinated package releases with dependency alignment across workspaces (mostly
package.json,CHANGELOG.md, andyarn.lock).@metamask/keyring-api@23.5.0is rolled out and referenced as^23.5.0from account and ETH keyring packages. Release notes documentresolveAccountAddresson v2KeyringSnapRpcplus a@metamask/superstructbump.Snap stack:
@metamask/keyring-snap-clientand@metamask/keyring-snap-sdkgo to 9.2.0 (client/SDK wiring forresolveAccountAddress);@metamask/keyring-internal-snap-clientto 10.0.5.@metamask/eth-snap-keyring@23.0.0is called out as breaking: v2SnapKeyringno longer extendsSnapKeyringV1— consumers use the.v1getter instead.Hardware wallets:
@metamask/hw-wallet-sdk@0.10.0is adopted by Ledger (12.3.0) and Trezor (10.1.1) keyrings. Changelogs note Ledger non-V4signTypedData→DeviceStateOnlyV4Supportedand Trezor user cancel/reject mapped toUserCancelled/UserRejectedvia the SDK.Several other packages only bump
@metamask/keyring-apito^23.5.0in[Unreleased]changelog lines without their own version bumps in this diff.Reviewed by Cursor Bugbot for commit 948aeae. Bugbot is set up for automated code reviews on this repo. Configure here.