chore: make package template a proper Yarn workspace - #10087
Draft
Mrtenz wants to merge 1 commit into
Draft
Conversation
Adds `scripts/create-package/package-template` to the monorepo's workspaces list so that Yarn constraints are enforced against it, making it easier to keep the template aligned with other packages. The template's package name is set to `@metamask/package-template` (a real resolvable name), with placeholders only for fields that vary per package. Constraints are relaxed where needed: the homepage uses a placeholder directory name, and the codeowner check is skipped for the template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
scripts/create-package/package-templatedirectory was not previously listed as a Yarn workspace, which meant Yarn constraints were not checked against it. This made it easy for the template to drift out of alignment with the monorepo's other packages over time.This PR adds the template to the workspaces list and gives it a real package name (
@metamask/package-template) so that constraints can run against it. Fields that vary per package (description, directory name) remain as placeholders. Constraints are relaxed in two places where the template legitimately differs from real packages: the homepage uses a placeholder directory name, and the code owner check is skipped.References
N/A
Checklist