feat(account-tree-controller)!: add strip{Metadata,Secrets} helpers on state snapshot - #10112
Merged
Merged
Conversation
… make metadata optional
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
ccharly
changed the title
ccharly
changed the title
strip{Metadata,Secrets} helpers on state snapshot
ccharly
marked this pull request as ready for review
September 7, 2026 11:01
ccharly
changed the title
strip{Metadata,Secrets} helpers on state snapshotstrip{Metadata,Secrets} helpers on state snapshot
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
gantunesr
reviewed
Sep 7, 2026
gantunesr
approved these changes
Sep 7, 2026
gantunesr
left a comment
gantunesr
left a comment
Member
There was a problem hiding this comment.
Looks good, left a small question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adding new
strip*helpers so we can mutate the snapshot before the onboarding proceed with the QR sync flow.References
N/A
Checklist
Note
Medium Risk
Breaking payload typings require consumer updates, and changes affect account-tree import paths that handle secrets and user-visible metadata.
Overview
Adds
AccountTreeSnapshot.stripSecrets()andstripMetadata()so callers can reshape an exported snapshot beforeimportState—for example applying layout/names in one step and mnemonics/private keys in another (QR sync onboarding).stripSecretsdrops mnemonic walletvalueand private-key groupvaluewhile keeping metadata;stripMetadataremoves wallet/group metadata while keeping secrets.This is paired with a breaking type/schema change:
metadatais optional on wallet and group payload entries (validated withexactOptional).import.tsnow skips name/pin/hidden updates when metadata is absent, matching stripped snapshots.Reviewed by Cursor Bugbot for commit d8fceea. Bugbot is set up for automated code reviews on this repo. Configure here.