Feat/add stellar bridge controller#8625
Open
Julink-eth wants to merge 8 commits intomainfrom
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0b037a5. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Adds Stellar support to
@metamask/bridge-controller, following the existing non-EVM patterns for Solana, Bitcoin, and Tron. This includes Stellar chain/native asset constants, CAIP formatting, default token metadata, quote validation, non-EVM fee handling via snapcomputeFee, and targeted test coverage.Also aligns Stellar asset formatting with the Bridge API contract:
stellar:pubnet/slip44:148stellar:pubnet/asset:CODE-ISSUERstellar:pubnet/sep41:C...References
Checklist
Note
Medium Risk
Introduces a new non‑EVM chain path (chainId/assetId formatting and quote validation), which could affect quote fetching/validation across supported chains if mappings are incorrect.
Overview
Adds Stellar (XLM pubnet) as a supported non‑EVM chain for
@metamask/bridge-controller, including newChainId.STELLAR, updated allowed chain lists/ranking, and native token metadata (symbol/decimals + SLIP-44 mapping).Extends bridge/CAIP utilities to recognize Stellar chainIds (
isStellarChainId, inclusion inisNonEvmChainId), convert Stellar chainIds to CAIP (stellar:pubnet), and format Stellar asset IDs for classic assets (asset:CODE-ISSUER) and Soroban contracts (sep41:C...). Quote request validation is tightened to requiredestWalletAddresswhen bridging to or from Stellar, and tests are added/updated to cover Stellar fee computation via SnapcomputeFeeand the new formatting/feature-flag scenarios.Reviewed by Cursor Bugbot for commit 54a48b6. Bugbot is set up for automated code reviews on this repo. Configure here.