Skip to content

fix: Make isVaultUpdated required on Encryptor #8650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
FrederikBolding wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Make isVaultUpdated required on Encryptor #8650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/keyring-controller/src/KeyringController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,14 +380,13 @@ export type Encryptor<
*/
decrypt: (password: string, encryptedString: string) => Promise<unknown>;
/**
* Optional vault migration helper. Checks if the provided vault is up to date
* with the desired encryption algorithm.
* Checks if the provided vault is up to date with the desired encryption algorithm.
*
* @param vault - The encrypted string to check.
* @param targetDerivationParams - The desired target derivation params.
* @returns The updated encrypted string.
*/
isVaultUpdated?: (
isVaultUpdated: (
vault: string,
targetDerivationParams?: encryptorUtils.KeyDerivationOptions,
) => boolean;
Expand Down Expand Up @@ -2755,7 +2754,7 @@ export class KeyringController<
#isNewEncryptionAvailable(): boolean {
const { vault } = this.state;

if (!vault || !this.#encryptor.isVaultUpdated) {
if (!vault) {
return false;
}

Expand Down
Loading