Open
Conversation
The tests for `createServicePolicy` are too exhaustive and are very painful to maintain. This commit rewrites the tests so that they focus on covering all lines instead of all code paths. Note that there are still some coverage issues with `createServicePolicy` because Istanbul treats the re-exported Cockatiel functions as untested. There doesn't seem to be a way around this short of switching to v8.
Contributor
Author
|
Adding |
mcmire
commented
May 1, 2026
|
|
||
| expect(mockService).toHaveBeenCalledTimes(1); | ||
| }); | ||
| describe('execute', () => { |
Contributor
Author
There was a problem hiding this comment.
Probably best to view this file on its own rather than going through the diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The tests for
createServicePolicyare too exhaustive and are very painful to maintain. This commit rewrites the tests so that they focus on covering all lines instead of all code paths.Note that there are still some coverage issues with
createServicePolicybecause Istanbul treats the re-exported Cockatiel functions as untested. There doesn't seem to be a way around this short of switching to v8. We may consider doing that in another commit, but that is out of scope for now.References
(Prerequisite for another PR that updates
createServicePolicy)Checklist