fix(assets-controller): seed native balances after account refresh#9388
Merged
Conversation
Zero-balancing for new accounts ran before getAssets on account-tree changes, so assetsBalance was often never populated for the new account. Seed native zero balances using the refreshed account list after the fetch.
This was referenced Jul 5, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d0d117f. Configure here.
Prithpal-Sooriya
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Zero-balancing for new accounts ran before getAssets on account-tree changes, so assetsBalance was often never populated for the new account. Seed native zero balances using the refreshed account list after the fetch.
assetsBalancefor newly added accounts on custom/RPC networks (e.g. DXC /eip155:50) whereassetsInfowas present but balances were not fetchedExplanation
References
Checklist
Note
Medium Risk
Changes balance refresh timing in
AssetsControllerfor account-tree and subscription flows; localized but affects wallet balance display on custom/RPC networks.Overview
Fixes cases where
assetsBalancestayed empty for new or RPC-only-network accounts even when metadata was present, by tightening whenAssetsControllerforce-refreshes balances.On account tree updates, the controller now tracks newly added accounts and, after the usual group-wide
getAssetsand re-subscribe, runs a second forced fetch scoped to those new accounts so the slow/RPC pipeline can populate balances (e.g. custom chains likeeip155:50).Documents the same class of fix for account group switches and newly enabled RPC-only networks in the changelog.
#handleEnabledNetworksChangedonly refactors to reuse a localaccountsvariable when fetching added chains—behavior unchanged.Reviewed by Cursor Bugbot for commit 8e87933. Bugbot is set up for automated code reviews on this repo. Configure here.