chore: return partial swap QuoteMetadata - #9507
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
micaelae
enabled auto-merge
July 14, 2026 19:10
micaelae
marked this pull request as draft
July 16, 2026 18:21
auto-merge was automatically disabled
July 16, 2026 18:21
Pull request was converted to draft
micaelae
force-pushed
the
swaps4546-refactor-quote-metadata
branch
from
July 20, 2026 23:10
0c70e76 to
d6c8c40
Compare
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
micaelae
marked this pull request as ready for review
July 22, 2026 00:24
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7158a56. Configure here.
micaelae
force-pushed
the
swaps4546-refactor-quote-metadata
branch
from
July 22, 2026 16:27
7158a56 to
0ad24e9
Compare
micaelae
changed the title
micaelae
enabled auto-merge
July 22, 2026 18:13
micaelae
changed the title
micaelae
changed the title
GeorgeGkas
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This extracts legacy QuoteMetadata code into its own directory to prepare for deprecation. See changelog/cursor comment for more details
Extension PR: MetaMask/metamask-extension#44630
Mobile PR: MetaMask/metamask-mobile#33559
References
Checklist
Note
High Risk
Breaking public API and fee/display semantics in a core swap-bridge package; extension and mobile must adopt the new
QuoteMetadatashape and gas field usage.Overview
Refactors legacy quote metadata out of the monolithic
utils/quote.tsintoutils/quote-metadata/(calcQuoteMetadata,mergeQuoteMetadata, types). Selectors now compute metadata viacalcQuoteMetadataand attach it withmergeQuoteMetadatainstead of inlining the old calculator block.Breaking
QuoteMetadatachanges: fields areDeepPartial/optional; missing fiat values areundefinedinstead ofnull/0.gasFee.effective,gasFee.max, andtotalMaxNetworkFeeare removed—callers should usegasFee.totalandtotalNetworkFee.priceImpactandrelayerFeeare newly computed and exposed. Quote validation moves tovalidators/quote-request.ts; perps sorting moves toutils/sort-quotes.ts. Publicindex.tsre-exports the new module; metricsusd_quoted_gasnow readsgasFee.total.Fee math tweaks include case-insensitive fee asset matching for
calcSentAmount, relayer fee handling when trade value is zero/negative, and simplified EVM gas display (total-only). Tests, mocks, and changelog document the consumer migration (extension/mobile PRs).Reviewed by Cursor Bugbot for commit 4348c39. Bugbot is set up for automated code reviews on this repo. Configure here.