fix: fix merge-approved-pr action path for cross-repo workflow calls#224
Merged
fix: fix merge-approved-pr action path for cross-repo workflow calls#224
Conversation
When metamask-mobile calls this reusable workflow, the relative path `./.github/actions/merge-approved-pr` resolves to the calling repo (metamask-mobile) instead of github-tools, causing the workflow to fail. Replace with an absolute ref so the action is always resolved correctly. Made-with: Cursor
chloeYue
requested review from
Gudahtt and
HowardBraham
and removed request for
a team
chloeYue
changed the title
jvbriones
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
metamask-mobile(or any external repo) calls this reusable workflow viaworkflow_call, the relative path:resolves against the calling repository, not
github-toolswhere the workflow is defined. GitHub looks formetamask-mobile/.github/actions/merge-approved-pr, which doesn't exist — causing the "Merge my PR" flow to silently fail.Example failing PR: MetaMask/metamask-mobile#27467
Fix
Replace the relative path with an absolute ref:
This ensures the action is always resolved from
github-toolsregardless of which repo triggers the reusable workflow.