ci: fix the release announcement Slack message#250
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns the use of
slackapi/slack-github-actionwith the other uses in this repo, and with the documentation: https://docs.slack.dev/tools/slack-github-action/sending-data-slack-incoming-webhook/Fixes: #249
Note
Low Risk
Low risk workflow-only change that alters Slack notification formatting and action configuration; main risk is missed/incorrect Slack pings if inputs or payload formatting are wrong.
Overview
Adjusts
publish-release.ymlto compute a release text frompackage.jsonand prepend an optional Slack subteam mention before posting.Updates the Slack step to use
slackapi/slack-github-actionincoming-webhook configuration viawith: webhook/webhook-type(instead of env vars) and keepscontinue-on-errorso Slack failures don’t block releases.Reviewed by Cursor Bugbot for commit 9337c1c. Bugbot is set up for automated code reviews on this repo. Configure here.