Repository navigation
Redact secret URL parameters in every log record - #396
Merged
Merged
Conversation
HttpApiKeyFilter only looked at records from the httpx logger and dropped them. Any other logger that prints a request URL (e.g. an HTTP error message) still wrote API keys to the console and log files: a SerpApi key reached the log files this way through a Google Trends seed source. The filter now rewrites every record, replacing the values of key, token, secret, signature and password query parameters with REDACTED, in the message, its arguments, exception text and stack info. httpx request lines are kept, redacted, instead of dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpApiKeyFilteronly looked at records from thehttpxlogger, and it dropped them. Any other logger that prints a request URL still wrote API keys to the console and toCustomLogger's log files.How this was found: a SerpApi key reached the log files through a Google Trends seed source in metaculus_ai_sdk, which logs the httpx error message (that message includes the full request URL). The SDK side is fixed in Metaculus/metac-ai-sdk#212.
What changes:
*key,*token,*secret,*signatureorpasswordwithREDACTED, in:emit()to report, as before. (A filter runs outsideHandler.handleError, so raising there would crash the caller.)formatExceptionkeep their own formatting.Not covered (out of scope): secrets outside URL query strings, such as
Authorizationheaders orapi_key='…'in kwargs reprs.Tests: 8 new unit tests in
code_tests/unit_tests/test_util/test_custom_logger.py:Full unit suite: the same 14 failures on unmodified
origin/mainand on this branch, intest_run_botsandtest_forecast_report. They're unrelated and pass when those files run alone.🤖 Generated with Claude Code