Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new configuration files and inference scripts for the flux2_klein model's image-to-image (i2i) edit task, while also fixing a typo in the scheduler's latent variable naming. Review feedback highlights issues with the shell scripts' portability, specifically recommending against hardcoded absolute paths and suggesting that empty path variables be initialized to the current directory to prevent incorrect file path resolution.
| @@ -1,5 +1,5 @@ | |||
| #!/bin/bash | |||
| lightx2v_path= | |||
| lightx2v_path=/mnt/miaohua/wangshankun/LightX2V | |||
There was a problem hiding this comment.
脚本中硬编码了绝对路径 /mnt/miaohua/wangshankun/LightX2V。这会导致脚本在其他开发者的环境下无法直接运行。建议将其设置为相对路径或保留为空，以提高脚本的可移植性。
| lightx2v_path=/mnt/miaohua/wangshankun/LightX2V | |
| lightx2v_path= |
| @@ -0,0 +1,15 @@ | |||
| #!/bin/bash | |||
| lightx2v_path= | |||
There was a problem hiding this comment.
lightx2v_path 被设置为空字符串，这会导致后续的路径拼接（如第 6 行的 source 命令和第 15 行的 --config_json）指向系统根目录（如 /scripts/...），这通常会因为路径不存在而导致脚本运行失败。建议将其默认值设置为 . 或在使用前进行有效性检查。
| lightx2v_path= | |
| lightx2v_path=. |
| @@ -0,0 +1,15 @@ | |||
| #!/bin/bash | |||
| lightx2v_path= | |||
There was a problem hiding this comment.
lightx2v_path 为空会导致脚本尝试访问根目录下的文件（如 /scripts/base/base.sh），建议设置合理的默认值（如 .）以确保脚本在仓库根目录下运行时能够正确找到相关文件。
| lightx2v_path= | |
| lightx2v_path=. |
2 participants
No description provided.