Clarify primary CTAs across Cycles and other pages - #69
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (14)
📝 WalkthroughWalkthroughThe PR standardizes CTA hierarchy across UI pages. It removes duplicate header actions, updates button styles, adds selected toggle styling, and restructures cycle creation, phase, export, and import controls. ChangesCTA hierarchy and cycle controls
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Modsofthenation
marked this pull request as ready for review
August 11, 2026 12:29
Keep a single solid primary action per screen (usually NextStep). Demote duplicate PageHeader/Section/table-row buttons to secondary or ghost so Cycles no longer shows Create cycle three times in neon green, and apply the same hierarchy on Team, Roles, Home, Settings, Writing Desk, and related pages. Co-authored-by: Damon <Modsofthenation@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/clarify-primary-ctas-3367
branch
from
August 11, 2026 12:30
bd04ca1 to
e05341d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cycles showed the same solid green Create cycle with directs CTA up to four times (header, NextStep banner, section chrome, and form). That made the call to action unclear.
Rule applied: NextStep owns the one solid primary action for “what to do now.” Duplicate PageHeader / Section / table-row actions use
secondaryorghost.Cycles (empty state)
Also tightened
Team, Roles, Home, Person, Promotions, Promotion detail, Writing desk, Settings, Consistency, Templates, Backfill
Test plan
pnpm --filter @prm/ui typecheckSummary by CodeRabbit