refactor!: improve C++ SDK header hygiene#10
Merged
Conversation
BREAKING CHANGE: moonbase::platform::linux was renamed to moonbase::platform::linux_os.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves public-header hygiene by splitting the CURL transport and native fingerprint provider into dedicated headers while keeping
moonbase::licensingintact. It intentionally renamesmoonbase::platform::linuxtomoonbase::platform::linux_osso public headers no longer undefine consumerlinuxorunixmacros. After merging latestmain, it also keeps the new cross-process file-locking path free of<windows.h>and preserves the online re-validation dedupe changes from v2.2.0. The branch also adds configurable HTTP timeouts, stricter UTC timestamp parsing, validation error consistency, top-level-only test/example defaults, and installed-package consumer smoke coverage.Validation
git diff --checkCMAKE_ARGS='-DCMAKE_OSX_SYSROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk' scripts/test.sh --clean --build-dir .context/post-merge-build(50/50 passed).context/post-merge-install