Repository navigation
UFlowNode_ComponentObserver: fix SuccessCount persistence on save during Success flow - #386
Merged
Merged
Conversation
UFlowNode_ComponentObserver: fix SuccessCount persistence on save during Success flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved SuccessCount increment before TriggerFirstOutput in OnEventReceived, so that if a save is triggered during the Success output flow, the count is already up-to-date at serialization time.
In OnLoad_Implementation, added a SuccessLimit check before calling StartObserving: if the node has already reached its limit, it triggers the Completed output directly instead of re-registering as an observer.