Repository navigation
Conversation
Collaborator
|
Hey, this is awesome and thanks for your PR. I'll try and get to it as soon as possible but life's a but busy right now. As this is a pretty huge PR it will also take a while to review unfortunately. |
Collaborator
|
I've begun my view but as there are so many files changed I'll have to do it manually and cannot therefore use the github built in tools to reference lines and files so here a list if things I've found:
|
Collaborator
What do you mean you mean? The screensaver2 page is used when having a screensaver but it's not display weather. |
added 2 commits
October 29, 2026 10:27
Resolve conflicts against devel's page-handler refactor and rebuilt assets: - MQTTManager tests: link both the Cover and Weather libraries. - React dist rebuilt from the merged sources; scripts.html regenerated. - Firmware and TFS images rebuilt from feat/cover-page merged with firmware devel (b1c7214), covering the new PageHandlers API.
- Log cover id and name when the controller check fails, as for other entity types. - Drop the scene-position check when placing a cover: covers cannot live on a scenes page, so a scene can never occupy the slot (test removed with it). - Keep documentation and research notes out of this repository; they live in NSPanelManager-docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds end-to-end cover support to NSPanelManager:
COVERentity type and migration;/rest/entities/coversand manager tests;coverpanel page, with quick open/close fallback for blinds/shutters on theentities page;
This implements the cover domain requested in #181: blinds, shutters, curtains, awnings, garage
doors, gates and windows. Tilt is intentionally out of scope for v1.
Panel UI
cover, on its own HMI page slot.screensaver2keeps its role as the "screensaverwithout weather" page and is not reused.
current,state(state + position),posslider,b_open,b_stop,b_close,home.cleanscreenis unchanged; the dropdown page still references it.Nextion page-RAM limit.
and checksum-validated.
Verification
tsc -b, production build pass.original_sonoffandcustom_pcbbuild successfully; flash usage 88.5% (Sonoff) and 84.9% (custom PCB).(270 EU, 180 US, 90 mirrored).
Panel-side testing (firmware and TFT on the device) has not been performed yet.
Hardware verification
Tested on a live Home Assistant installation (aarch64) running the manager built from this branch:
the existing installation was upgraded in place, migrations
0069/0070applied cleanly, andCover shows up in the add/edit entity wizard.
Release coupling
The firmware binaries and rebuilt TFTs are committed here so the manager, firmware and panel UI
ship together. The binaries are built from the companion branch merged with firmware
devel(
b1c7214), so they include the recent panel fixes (#49, #50, #52) on top of the cover page.The companion firmware PR contains the source changes: