[Replay] Add McapTrackerViewers to read mcap file.#396
Open
shaosu-nvidia wants to merge 4 commits intossx/replay/latest_channelfrom
Open
[Replay] Add McapTrackerViewers to read mcap file.#396shaosu-nvidia wants to merge 4 commits intossx/replay/latest_channelfrom
shaosu-nvidia wants to merge 4 commits intossx/replay/latest_channelfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
nvddr
reviewed
Apr 15, 2026
shaosu-nvidia
changed the title
qingsi-at-nv
approved these changes
Apr 16, 2026
nvddr
reviewed
Apr 17, 2026
nvddr
reviewed
Apr 17, 2026
Following the same pattern of McapTrackerChannels - it takes a McapReader and a list of channels we want to replay - internally it keeps the MessageView and iterator to read message one by one.
shaosu-nvidia
force-pushed
the
ssx/replay/mcap_reader
branch
from
d6f6139 to
23f5574
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the same pattern of McapTrackerChannels