[Replay] Add replay_deviceio_session#401
[Replay] Add replay_deviceio_session#401shaosu-nvidia wants to merge 5 commits intossx/replay/replay_trackersfrom
Conversation
shaosu-nvidia
commented
Apr 16, 2026
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
|
||
| // ============================================================================ | ||
| // DeviceIOSession Implementation | ||
| // LiveDeviceIOSession (private) |
There was a problem hiding this comment.
Can you help me understand how LiveDeviceIOSession and ReplayDeviceIOSession are private after the change? Their ctors are still public. Are they hidden via a build rule?
6b4bc14 to
bbaed41
Compare
1. ReplayDeviceIOSession takes an existing MCAP file and a map of trackers that should be replayed and the channel name that they got recorded in the passed mcap file 2. In each update call, it pulls one record from the mcap file for each tracker and it's channels 3. Refactor the existing DeviceIOSession to LiveDeviceIOSession and add creator functions to create either LiveDeviceIOSession or ReplayDeviceIOSession. Both of them share the same python interface.
0ce9ed6 to
00550de
Compare