Skip to content

[Replay] Add replay_deviceio_session#401

Open
shaosu-nvidia wants to merge 5 commits intossx/replay/replay_trackersfrom
ssx/replay/replay_deviceio_session
Open

[Replay] Add replay_deviceio_session#401
shaosu-nvidia wants to merge 5 commits intossx/replay/replay_trackersfrom
ssx/replay/replay_deviceio_session

Conversation

@shaosu-nvidia
Copy link
Copy Markdown
Contributor

1. ReplayDeviceIOSession takes an existing MCAP file and a map of
   trackers that should be replayed and the channel name that they got
recorded in the passed mcap file

2. In each update call, it pulls one record from the mcap file for each
   tracker and it's channels

3. Refactor the existing DeviceIOSession to LiveDeviceIOSession and add
   creator functions to create either LiveDeviceIOSession or
ReplayDeviceIOSession. Both of them share the same python interface.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f4e5c7bb-93a9-4544-b26c-1d672e1e2d28

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ssx/replay/replay_deviceio_session

Comment @coderabbitai help to get the list of available commands and usage tips.


// ============================================================================
// DeviceIOSession Implementation
// LiveDeviceIOSession (private)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me understand how LiveDeviceIOSession and ReplayDeviceIOSession are private after the change? Their ctors are still public. Are they hidden via a build rule?

@shaosu-nvidia shaosu-nvidia force-pushed the ssx/replay/replay_trackers branch from 6b4bc14 to bbaed41 Compare April 17, 2026 23:30
1. ReplayDeviceIOSession takes an existing MCAP file and a map of
   trackers that should be replayed and the channel name that they got
recorded in the passed mcap file

2. In each update call, it pulls one record from the mcap file for each
   tracker and it's channels

3. Refactor the existing DeviceIOSession to LiveDeviceIOSession and add
   creator functions to create either LiveDeviceIOSession or
ReplayDeviceIOSession. Both of them share the same python interface.
@shaosu-nvidia shaosu-nvidia force-pushed the ssx/replay/replay_deviceio_session branch from 0ce9ed6 to 00550de Compare April 17, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants