MBridge pruning minor fix for saving pruned NemotronH#887
MBridge pruning minor fix for saving pruned NemotronH#887kevalmorabia97 merged 1 commit intomainfrom
Conversation
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
📝 WalkthroughWalkthroughThe changes introduce rank-0 aware logging improvements in a searcher utility, update a method signature to respect a trust_remote_code flag during model loading, and add documentation comments in example files regarding future validation configuration refactoring. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
=======================================
Coverage 73.73% 73.74%
=======================================
Files 199 199
Lines 21165 21163 -2
=======================================
Hits 15606 15606
+ Misses 5559 5557 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| manual_gc_interval=100, | ||
| ), | ||
| # TODO: Replace validation args in train with validation config in nemo:26.04 | ||
| # validation=ValidationConfig(eval_interval=args.eval_interval, eval_iters=args.eval_iters), |
There was a problem hiding this comment.
will you implement this in the current PR or a later PR?
There was a problem hiding this comment.
Later. It wont be merged into 26.02 container so will raise error if we do it now but wanted to keep it for reference incase we try to mount latest m-bridge and run the script
What does this PR do?
Type of change: Bug fix
Testing
Nemotron Nano v2 pruned can be saved
Summary by CodeRabbit
Bug Fixes
trust_remote_codeparameter during model instantiation.Improvements