Skip to content

[https://nvbugs/6435097][fix] Remove the single stale nvbugs/6427411 waiver line for…#16266

Open
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6435097
Open

[https://nvbugs/6435097][fix] Remove the single stale nvbugs/6427411 waiver line for…#16266
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6435097

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • Verify fix on the same GPU type as the original failure
  • Check for regressions in related tests

Links

Summary by CodeRabbit

  • Tests
    • Removed an obsolete exception from the integration test suite.
    • The affected scenario is now validated normally instead of being skipped, improving test coverage and confidence in serving behavior.

The TorchSampler IndexError described in nvbug 6435097 was introduced by
PR NVIDIA#15920 ("Move greedy stop checks to host") and cleanly reverted by
PR NVIDIA#16163 (commit 9a8ec05). PR NVIDIA#16163 is already present at HEAD, so
the underlying code bug is fixed.

The waiver at nvbugs/6427411 for
test_ctx_pp_gen_tp_asymmetric[GSM8K-gen_tp=1-ctx_pp=2] was added by
PRs NVIDIA#16103 / NVIDIA#16105 / NVIDIA#16127 before the revert landed and was not
cleaned up afterward.

Verified locally on this HEAD (e523b43):
  pytest tests/integration/defs/accuracy/test_disaggregated_serving.py::\
    TestLlama3_1_8BInstruct::test_ctx_pp_gen_tp_asymmetric[GSM8K-gen_tp=1-ctx_pp=2]
  -> PASSED, GSM8K accuracy = 73.465 (threshold 70.997).

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a717fab9-1d0e-4bf7-9993-81af19ff6a6f

📥 Commits

Reviewing files that changed from the base of the PR and between b4e7808 and 03137a5.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

The integration waiver list removes the SKIP entry for the Llama 3.1 8B Instruct asymmetric context/parallelism test configuration.

Changes

Waiver list update

Layer / File(s) Summary
Remove disaggregated-serving test waiver
tests/integration/test_lists/waives.txt
Removes the waiver for test_ctx_pp_gen_tp_asymmetric with GSM8K-gen_tp=1-ctx_pp=2.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: mzweilz, nv-guomingz

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change and follows the required ticket/type pattern, even though it is slightly truncated.
Description check ✅ Passed The description is mostly complete with summary, fix details, test plan, and bug link, though the checklist section is omitted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants