[https://nvbugs/6435097][fix] Remove the single stale nvbugs/6427411 waiver line for…#16266
Open
trtllm-agent wants to merge 1 commit into
Open
[https://nvbugs/6435097][fix] Remove the single stale nvbugs/6427411 waiver line for…#16266trtllm-agent wants to merge 1 commit into
nvbugs/6427411 waiver line for…#16266trtllm-agent wants to merge 1 commit into
Conversation
The TorchSampler IndexError described in nvbug 6435097 was introduced by PR NVIDIA#15920 ("Move greedy stop checks to host") and cleanly reverted by PR NVIDIA#16163 (commit 9a8ec05). PR NVIDIA#16163 is already present at HEAD, so the underlying code bug is fixed. The waiver at nvbugs/6427411 for test_ctx_pp_gen_tp_asymmetric[GSM8K-gen_tp=1-ctx_pp=2] was added by PRs NVIDIA#16103 / NVIDIA#16105 / NVIDIA#16127 before the revert landed and was not cleaned up afterward. Verified locally on this HEAD (e523b43): pytest tests/integration/defs/accuracy/test_disaggregated_serving.py::\ TestLlama3_1_8BInstruct::test_ctx_pp_gen_tp_asymmetric[GSM8K-gen_tp=1-ctx_pp=2] -> PASSED, GSM8K accuracy = 73.465 (threshold 70.997). Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe integration waiver list removes the ChangesWaiver list update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use_host_stop_criteriafast path that under-populated per-step/seq_slot/beam token buffers on non-last PP ranks, causing IndexError; PR [TRTLLM-14155][fix] Revert host-side greedy stop checks from #15920 #16163 (commit 9a8ec05) reverted PR [None][perf] Move greedy stop checks to host #15920 and is present at HEAD, so the code is already fixed. The waiver line for this test was left behind by cleanup PRs [https://nvbugs/6427411][chore] Waive failed tests in Pre-merge #16103/[https://nvbugs/6427411][chore] Waive a failed test in Pre-merge #16105/[https://nvbugs/6427411][chore] Waive remaining PP sampler regressions #16127.nvbugs/6427411waiver line fortest_ctx_pp_gen_tp_asymmetric[GSM8K-gen_tp=1-ctx_pp=2]inwaives.txt; do not touch other test entries or other bug IDs.Test plan
Links
Summary by CodeRabbit