Skip to content

[https://nvbugs/6367792][fix] unwaive Nano AutoDeploy tests#16285

Open
tcherckez-nvidia wants to merge 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:nvbug6367792-unwaive-nano-tests
Open

[https://nvbugs/6367792][fix] unwaive Nano AutoDeploy tests#16285
tcherckez-nvidia wants to merge 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:nvbug6367792-unwaive-nano-tests

Conversation

@tcherckez-nvidia

@tcherckez-nvidia tcherckez-nvidia commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Updated accuracy test waivers to remove resolved skip conditions.
    • Retained a temporary waiver for one NVFP4 configuration with accuracy below the required threshold.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c040c853-1be4-432b-85f9-64cb36e2a995

📥 Commits

Reviewing files that changed from the base of the PR and between 1c9a902 and 08ecc3c.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Updates Nemotron Nano V3 accuracy-test waivers by removing three configuration skips and revising the remaining NVFP4 waiver note.

Changes

Nemotron accuracy waivers

Layer / File(s) Summary
Update accuracy waiver entries
tests/integration/test_lists/waives.txt
Removes three accuracy-test SKIP entries and updates the remaining NVFP4 entry with the temporary ToT main waiver explanation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: dongxuy04, pcastonguay, yuxianq

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The template is present, but the Description and Test Coverage sections are empty, so the PR lacks required context. Add a short problem/solution summary and list the tests or validation used to verify the unwaive change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the PR's main change and follows the repository's ticket/type format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: tcherckez-nvidia <127761168+tcherckez-nvidia@users.noreply.github.com>
@tcherckez-nvidia tcherckez-nvidia force-pushed the nvbug6367792-unwaive-nano-tests branch from 08ecc3c to 47ef68e Compare July 12, 2026 09:25
@tcherckez-nvidia

Copy link
Copy Markdown
Collaborator Author

bot run --extra-stage "DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1,DGX_B200-4_GPUs-AutoDeploy-Post-Merge-1,DGX_B200-AutoDeploy-Post-Merge-1"

@tcherckez-nvidia

Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1,DGX_B200-4_GPUs-AutoDeploy-Post-Merge-1,DGX_B200-AutoDeploy-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58807 [ run ] triggered by Bot. Commit: 47ef68e Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58807 [ run ] completed with state DISABLED
Pipeline is freezed and top-1 instance is under maintenance.

Link to invocation

Copy link
Copy Markdown
Collaborator

/bot run --extra-stage "DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1,DGX_B200-4_GPUs-AutoDeploy-Post-Merge-1,DGX_B200-AutoDeploy-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58834 [ run ] triggered by Bot. Commit: 47ef68e Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58834 [ run ] completed with state SUCCESS. Commit: 47ef68e
/LLM/main/L0_MergeRequest_PR pipeline #47387 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants