[PyTorch] Allow CP P2P transport group overrides - #3420
Draft
xiaoyao0115 wants to merge 1 commit into
Draft
Conversation
xiaoyao0115
force-pushed
the
cp-p2p-transport
branch
from
August 25, 2026 09:49
b395b7b to
a4df553
Compare
Signed-off-by: Tailai Ma <tailaim@ferries-work.nvidia.com>
xiaoyao0115
force-pushed
the
cp-p2p-transport
branch
from
August 25, 2026 09:52
2121c6b to
7feb354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isend/irecvthrough that transport groupMotivation
Dynamic CP CUDA graphs capture multiple logical CP sizes. Initializing one NCCL communicator per logical CP group adds persistent communicator memory. The companion Megatron Core change maps those logical groups to one pre-warmed parent communicator during graph warmup and capture.
The default path is unchanged when no override is registered.
This change was split from #3353 so the transport API can be reviewed independently from CUDA Graph slot-memory sharing.
Validation
common/activation/gelu.cu:fatbinarycannot opengelu.compute_75.ptx; this PR changes PyTorch files onlyCompanion change