Skip to content

[Common] Default EP comm kernels to 32 SMs; keep shuffle/preprocess on all SMs - #3422

Merged
phu0ngng merged 2 commits into
NVIDIA:mainfrom
phu0ngng:ep-sm-defaults
Aug 26, 2026
Merged

[Common] Default EP comm kernels to 32 SMs; keep shuffle/preprocess on all SMs#3422
phu0ngng merged 2 commits into
NVIDIA:mainfrom
phu0ngng:ep-sm-defaults

Conversation

@phu0ngng

Copy link
Copy Markdown
Collaborator

Description

Set a sane default SM budget for EP dispatch/combine (32 SMs) while leaving the local shuffle/preprocess kernels on all device SMs.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…s on all SMs

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
@phu0ngng

Copy link
Copy Markdown
Collaborator Author

/te-ci L1

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR changes the default NCCL EP communication-kernel budget to 32 SMs, clamped to the device SM count.

  • Leaves shuffle and preprocessing kernels on all available SMs unless their environment variables are already configured.
  • Updates the public C and JAX API documentation for the new communication-kernel default.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains.

No blocking failure remains.

Important Files Changed

Filename Overview
transformer_engine/common/ep/ep_backend.cpp Applies the clamped 32-SM communication default and initializes shuffle and preprocessing SM environment defaults.
transformer_engine/common/include/transformer_engine/ep.h Documents the revised semantics of a zero communication-SM budget in the public C API.
transformer_engine/jax/ep.py Updates the JAX bootstrap documentation to describe the 32-SM communication default.

Reviews (2): Last reviewed commit: "Merge branch 'main' into ep-sm-defaults" | Re-trigger Greptile

Comment on lines 245 to +247
cfg.max_num_sms = group_config.num_comm_sms > 0
? static_cast<unsigned int>(group_config.num_comm_sms)
: NCCL_EP_AUTO;
: static_cast<unsigned int>(std::min(kDefaultCommSms, device_sms));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Stale zero-budget diagnostic

The implementation now maps num_comm_sms == 0 to min(32, device_sms), but the native validation message still describes zero as automatic sizing, misleading users who are diagnosing or selecting the communication-kernel SM budget.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@jberchtold-nvidia jberchtold-nvidia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phu0ngng
phu0ngng merged commit e6690f4 into NVIDIA:main Aug 26, 2026
12 of 16 checks passed
@phu0ngng
phu0ngng deleted the ep-sm-defaults branch August 26, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants