[JAX] Fix classification of sync-tagged collective start instructions - #3425
Merged
KshitijLakhani merged 1 commit intoAug 26, 2026
Conversation
Contributor
Greptile SummaryThe PR fixes JAX distributed-test collective accounting by prioritizing explicit
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "[JAX] Fix sync-tagged collective start c..." | Re-trigger Greptile |
KshitijLakhani
marked this pull request as draft
August 25, 2026 22:17
Signed-off-by: Kshitij Janardan Lakhani <klakhani@nvidia.com>
KshitijLakhani
force-pushed
the
klakhani/fix/jax-sync-tagged-collective-start
branch
from
August 25, 2026 22:19
0bee041 to
ef0887c
Compare
KshitijLakhani
marked this pull request as ready for review
August 25, 2026 22:20
Collaborator
Author
|
/te-ci jax L0 L1 |
jberchtold-nvidia
approved these changes
Aug 25, 2026
jberchtold-nvidia
left a comment
Collaborator
There was a problem hiding this comment.
LGTM pending CI, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix JAX collective-byte accounting when XLA emits an
all-reduce-startinstruction with"is_sync":true.The parser previously treated this as an unsuffixed synchronous collective and classified the communication bytes as
other. This change prioritizes the explicit*-startinstruction form.No LayerNorm/RMSNorm implementation or expected byte calculations are changed.
Type of change
Changes
Checklist: