[cuda.compute]: add back CI for CTK 12.0 - #10057
Merged
Merged
Conversation
Previously, Python test scripts extracted only the major version from nvcc (e.g. 12) and installed cuda-toolkit==12.*, which floated to the latest 12.x from PyPI regardless of the container's actual CTK version. This masked issues like the nvrtc compiler bug in CTK 12.4. Use PIP_CONSTRAINT to pin cuda-toolkit==X.Y.* (e.g. 12.9.*) matching the container's nvcc, ensuring CI tests exercise the exact same cuda-toolkit minor version as the devcontainer. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Contributor
Author
|
/ok to test 707ed05 |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test a40ed81 |
Contributor
Author
|
/ok to test eabd8ac |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR restores CTK 12.0 coverage across selected Python CI matrix entries and conditionally skips cooperative CUDA examples when ChangesCTK 12.0 Python coverage
Assessment against linked issues
Possibly related PRs
Suggested reviewers: Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 17ce6224-c87c-4313-848c-0caf82ef5b68
📒 Files selected for processing (2)
ci/matrix.yamlpython/cuda_cccl/tests/test_examples.py
Contributor
Author
|
/ok to test 025c04a |
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 30m: Pass: 100%/532 | Total: 4d 05h | Max: 2h 21m | Hits: 99%/673170See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #8156
Merge first: #8160
Checklist