Prepare select and partition tuning policies for lookahead#10076
Open
bernhardmgruber wants to merge 3 commits into
Open
Prepare select and partition tuning policies for lookahead#10076bernhardmgruber wants to merge 3 commits into
bernhardmgruber wants to merge 3 commits into
Conversation
10 tasks
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (12)
🚧 Files skipped from review as they are similar to previous changes (10)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesLookback tuning policies now use explicit algorithm discriminators and nested payload structs. Device dispatch, benchmarks, and tests are updated to construct and consume the new Suggested labels: Suggested reviewers: Comment |
This comment has been minimized.
This comment has been minimized.
Contributor
The line 72 reads: but earlier line 37 seem to be using exact same thing without triggering error: |
bernhardmgruber
force-pushed
the
tune_select_part
branch
from
July 22, 2026 15:13
4874f7f to
4c7f2cd
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 54m: Pass: 100%/287 | Total: 13d 15h | Max: 2h 42m | Hits: 17%/1269016See results here. |
davebayer
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of: #10075