Fix undefined TUNE_LOAD_ALGORITHM in scan benchmark .variant builds#10212
Open
gonidelis wants to merge 1 commit into
Open
Fix undefined TUNE_LOAD_ALGORITHM in scan benchmark .variant builds#10212gonidelis wants to merge 1 commit into
TUNE_LOAD_ALGORITHM in scan benchmark .variant builds#10212gonidelis wants to merge 1 commit into
Conversation
TUNE_LOAD_ALGORITHM in scan benchmark .variant builds
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesScan tuning
Suggested reviewers: Comment |
Contributor
😬 CI Workflow Results🟥 Finished in 2h 43m: Pass: 99%/242 | Total: 12d 05h | Max: 2h 38m | Hits: 16%/920258See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cub/benchmarks/bench/scan/policy_selector.hconsumesTUNE_LOAD_ALGORITHM/TUNE_LOAD_MODIFIER/TUNE_STORE_ALGORITHM, butsum.cu's%RANGE%axes only defineTUNE_TRANSPOSE/TUNE_LOAD. The translation block every other lookback bench carries (partition,select,by_key) is missing from the scan chain.That results for every
scan.exclusive.sumvariant build to fail with "identifier TUNE_LOAD_ALGORITHM is undefined". The scan tuning is broken upstream on every architecture. This is invisible in CI because.varianttargets are never built there which is something that has led to other problems in the past.I ran a dummy tuning to verify that the fix works since no tests exist.
(cccl) root ➜ /src/fixtest/cccl (scan_tuning_bug) $ CIQ_GPU=0 CIQ_POOL=32 CIQ_GENERATIONS=1 python3 /src/compileiq_search.py \ -R '^cub\.bench\.scan\.exclusive\.sum$' -a 'T{ct}=I32' -a 'OffsetT{ct}=I32' \ -DCMAKE_CUDA_ARCHITECTURES=native cmake ../.. -DCUB_ENABLE_BENCHMARKS=YES -DCUB_ENABLE_TUNING=YES -DCCCL_ENABLE_THRUST=OFF -DCCCL_ENABLE_LIBCUDACXX=OFF -DCCCL_ENABLE_CUB=ON -DCCCL_ENABLE_TESTING=OFF -DCUB_ENABLE_DIALECT_CPP11=OFF -DCUB_ENABLE_DIALECT_CPP14=OFF -DCUB_ENABLE_DIALECT_CPP17=ON -DCUB_ENABLE_DIALECT_CPP20=OFF -DTHRUST_IGNORE_DEPRECATED_CPP_DIALECT=ON -DCUB_ENABLE_RDC_TESTS=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_CUDA_ARCHITECTURES=native ctk: 13.4.46 cccl: monorepo-5367-g0bfeaa0611 Driver-side probe evaluation: {'ipt': 7, 'tpb': 128, 'ns': 0, 'dcid': 0, 'l2w': 0, 'trp': 0, 'ld': 0} cub.bench.scan.exclusive.sum.ipt_7.tpb_128.ns_0.dcid_0.l2w_0.trp_0.ld_0 0.4714180865641916 Probe score: 0.4714180865641916ping @bernhardmgruber