Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test 1bb3f5f |
|
|
Important Review skippedWe couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 Summary
Priority: ➖ Normal Change: Refactor · Severity of issue fixed: Medium Merge Risk: 🔵 Low · up to
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: NVIDIA/cuda-python/.coderabbit.yaml
- Review profile: CHILL
- Plan: Enterprise
- Run ID:
5a3ae4e1-a4c6-40a5-a885-ffeebb6e4995
📒 Files selected for processing: 6
.pre-commit-config.yamlCONTRIBUTING.mdcuda_bindings/docs/source/install.rstcuda_core/_build_shared.pycuda_core/_build_shared.pycuda_core/docs/source/install.rst
💤 Files with no reviewable changes: 1
- .pre-commit-config.yaml
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
| for details and recovery steps. Windows contributors building outside of | ||
| WSL should also see | ||
| `Development on Windows | ||
| <https://github.com/NVIDIA/cuda-python/blob/main/CONTRIBUTING.md#development-on-windows>`_ | ||
| for the git-symlink configuration that must be set *before* cloning. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
nl -ba cuda_core/docs/source/install.rst | sed -n '95,205p'
nl -ba CONTRIBUTING.md | sed -n '40,60p;145,210p'Repository: NVIDIA/cuda-python
Length of output: 8817
🏁 Script executed:
nl -ba cuda_core/docs/source/install.rst | sed -n '1,94p'Repository: NVIDIA/cuda-python
Length of output: 3991
important: Move the Windows symlink requirement before the clone commands.
The earlier page context only introduces the development workflow. It does not state the Windows prerequisite. Native Windows users can therefore clone before enabling Git symlinks. Git can then check out cuda_core/_build_shared.py as a text file, which breaks cuda-core source builds and tests. Place the warning, or a link to the setup instructions, before the uv, pixi, and source-install clone commands.
There was a problem hiding this comment.
I moved this PR back to draft, after looking into this coderabbit finding. It made it obvious to me that the existing sections are in an awkward order. It'll be a more structural change to move the Installing from Source section first, but I think this is the right PR to do it.
There was a problem hiding this comment.
@rwgk suggestion: Moving “Installing from Source” before the uv and pixi workflows gives the shared prerequisites a clear place. Put the Windows symlink setup link before that section’s clone command so readers see it before checkout.
You are interacting with an AI system.
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Description
Follow-up to #3036 and #3000. Now that the QA cycle covered by #3036 is complete, restore
cuda_core/_build_shared.pyas a symlink to the canonicalcuda_bindings/_build_shared.pyand remove the temporary copy-sync pre-commit check.The documentation identifies the current representation while keeping the shared-helper contract compatible with an identical copy if needed later. It also documents native Windows Git symlink setup, including the Developer Mode registry value required for unelevated checkouts.
Checklist