Skip to content

Minimize Ubuntu Boost dependencies#1165

Open
bdice wants to merge 3 commits intoNVIDIA:mainfrom
bdice:minimize-boost-deps
Open

Minimize Ubuntu Boost dependencies#1165
bdice wants to merge 3 commits intoNVIDIA:mainfrom
bdice:minimize-boost-deps

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented Apr 30, 2026

Summary

  • install only the Boost components needed by cuOpt's PaPILO dependency on Ubuntu
  • add libboost-iostreams-dev and libboost-serialization-dev explicitly rather than libboost-dev
  • skip libboost-program-options-dev -- this is optional and not needed for PaPILO with the options we provide (PAPILO_NO_BINARIES=ON)

@bdice bdice requested a review from a team as a code owner April 30, 2026 16:44
@bdice bdice requested a review from jameslamb April 30, 2026 16:44
@bdice bdice marked this pull request as draft April 30, 2026 16:47
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 30, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

📝 Walkthrough

Walkthrough

The ci/utils/install_boost_tbb.sh script was modified to extend its SPDX copyright year range and to install specific Boost development packages (libboost-iostreams-dev, libboost-serialization-dev) instead of the generic libboost-dev on Ubuntu, while retaining libtbb-dev.

Changes

Cohort / File(s) Summary
Build Script Dependencies
ci/utils/install_boost_tbb.sh
SPDX year range extended; Ubuntu apt-get line changed to install libboost-iostreams-dev and libboost-serialization-dev (replacing libboost-dev) and continue installing libtbb-dev.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: minimizing Ubuntu Boost dependencies by installing only specific components instead of the broad libboost-dev package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description accurately describes the changeset, detailing the specific Boost package modifications and the rationale for avoiding broad Boost dependencies.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bdice bdice force-pushed the minimize-boost-deps branch from 4eb9f46 to e69f157 Compare April 30, 2026 16:50
@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented Apr 30, 2026

/ok to test

@bdice bdice marked this pull request as ready for review April 30, 2026 20:30
@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Apr 30, 2026
Copy link
Copy Markdown
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thanks!

I just merged latest main in here to trigger a new CI run. Hopefully things will go better now that the *.ubuntu.com servers are somewhat stabilizing (https://status.canonical.com/).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants