feat(slurm): add QOS support to SlurmBackendConfig#2
Draft
v-shobhit wants to merge 1 commit intoNVIDIA:mainfrom
Draft
feat(slurm): add QOS support to SlurmBackendConfig#2v-shobhit wants to merge 1 commit intoNVIDIA:mainfrom
v-shobhit wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Add `qos` field to `SlurmBackendConfig` so that a `qos:` declaration in sflow YAML backend blocks is no longer silently ignored. When `qos` is set (non-empty), `--qos <value>` is appended to the `salloc` command. The field is optional (`None` by default) so existing workflows that omit it are unaffected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Seems there is an Converting to draft while I am looking into this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
qosfield toSlurmBackendConfigso that aqos:declaration in sflow YAML backend blocks is no longer silently ignored.When
qosis set (non-empty),--qos <value>is appended to thesalloccommand. The field is optional (Noneby default) so existing workflows that omit it are unaffected.