Fix/srun container flags bare metal#3
Open
v-shobhit wants to merge 2 commits intoNVIDIA:mainfrom
Open
Conversation
v-shobhit
commented
Apr 10, 2026
v-shobhit
commented
When a Jinja2 conditional in extra_args evaluates to an empty string
(e.g. `${{ '--qos=' + variables.SLURM_QOS if variables.SLURM_QOS else '' }}`),
the resolved empty string was previously passed verbatim to salloc,
causing it to fail with an unrecognised argument.
Strip and skip empty-string items after resolution so that optional
salloc flags can be expressed as conditional template expressions.
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
--no-container-mount-home and --container-writable were unconditionally added to every srun command regardless of whether container_image or container_name was set. This caused bare-metal operators (e.g. a plain host_runner with no container) to get spurious Pyxis flags that activated a container namespace without an image, restricting the process environment and triggering ulimit -u failures in Go runtimes (errno=11 from pthread_create). Gate all Pyxis flags on _using_container (container_image or container_name is set). Bare-metal srun steps are now unaffected. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.