Skip to content

Make spawn accept lvalue scope tokens#1966

Open
gamecentric wants to merge 1 commit intoNVIDIA:mainfrom
gamecentric:main
Open

Make spawn accept lvalue scope tokens#1966
gamecentric wants to merge 1 commit intoNVIDIA:mainfrom
gamecentric:main

Conversation

@gamecentric
Copy link
Copy Markdown

Spawn only accepts rvalues scope tokens, which is unexpected, since tokens are typically value-oriented, cheaply copiable, objects:

counting_scope scope;
spawn(just(), scope.get_token()); // ok

auto token = scope.get_token();
spawn(just(), token); // error: counting_scope::token& does not satisfy the scope_token concept
spawn(just(), std::move(token)); // ok

See issue #1963

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 27, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant