Skip to content

Fix constrained worker selection - #2179

Merged
ericniebler merged 2 commits into
NVIDIA:mainfrom
fallintoplace:fix/constrained-worker-selection
Aug 11, 2026
Merged

Fix constrained worker selection#2179
ericniebler merged 2 commits into
NVIDIA:mainfrom
fallintoplace:fix/constrained-worker-selection

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • select the round-robin target from the eligible worker count
  • preserve the existing fallback when no pool workers match the mask
  • add a regression test with a synthetic two-node NUMA policy

The constrained selection path reduced its target modulo the full pool size before walking only the eligible workers. When the eligible set was smaller than the pool, indices beyond that set fell through the traversal and were returned as raw worker indices, allowing work to be queued on an excluded node.

The regression test uses four workers split across two synthetic nodes. Before this change, two of four consecutive submissions ran on the excluded node.

Testing

  • full test.exec suite: 3,302 assertions in 327 test cases
  • full test.exec suite with -fno-exceptions: 3,244 assertions in 309 test cases
  • regression test repeated 100 times

@copy-pr-bot

copy-pr-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericniebler ericniebler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test d551f34

@fallintoplace

Copy link
Copy Markdown
Contributor Author

Some clang format errors appear but I can only fix tomorrow.

@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 7024d2c

@ericniebler
ericniebler merged commit e85d9a1 into NVIDIA:main Aug 11, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants