Fix constrained worker selection - #2179
Merged
ericniebler merged 2 commits intoAug 11, 2026
Merged
Conversation
Collaborator
|
/ok to test d551f34 |
Contributor
Author
|
Some clang format errors appear but I can only fix tomorrow. |
Collaborator
|
/ok to test 7024d2c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The constrained selection path reduced its target modulo the full pool size before walking only the eligible workers. When the eligible set was smaller than the pool, indices beyond that set fell through the traversal and were returned as raw worker indices, allowing work to be queued on an excluded node.
The regression test uses four workers split across two synthetic nodes. Before this change, two of four consecutive submissions ran on the excluded node.
Testing