Fix repeat receiver lifetime after cleanup - #2187
Merged
ericniebler merged 3 commits intoAug 11, 2026
Merged
Conversation
Collaborator
|
/ok to test 3e3af77 |
Collaborator
|
/ok to test bc767f6 |
Collaborator
|
/ok to test fd72a80 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repeat_nandrepeat_untilWhy
Cleanup resets the child operation, which owns the repeat receiver that is currently completing. Reading
__state_from that receiver after cleanup accesses an object whose lifetime has ended.Testing
test.execsuite: 3,326 assertions across 328 test cases[repeat_n]and[repeat_until]test groups-fno-exceptions