Skip to content

Fix schedule_all move-only range support #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fallintoplace wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

Fix schedule_all move-only range support #2203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/exec/static_thread_pool.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1652,7 +1652,7 @@ namespace experimental::execution
struct opstate_base_with_receiver : opstate_base<Range>
{
explicit opstate_base_with_receiver(Range range, _static_thread_pool& pool, Receiver rcvr)
: opstate_base<Range>{range, pool}
: opstate_base<Range>{std::move(range), pool}
, rcvr_(static_cast<Receiver&&>(rcvr))
{}

Expand Down
13 changes: 13 additions & 0 deletions test/exec/test_static_thread_pool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,19 @@ TEST_CASE("schedule_all on static_thread_pool handles empty ranges", "[types][st
CHECK(ex::sync_wait(std::move(sender)));
}

TEST_CASE("schedule_all on static_thread_pool accepts move-only ranges",
"[types][static_thread_pool]")
{
exec::static_thread_pool pool{1};
int sum = 0;
auto sender = exec::schedule_all(pool, std::views::all(std::vector<int>{1, 2, 3}))
| exec::transform_each(ex::then([&sum](int value) noexcept { sum += value; }))
| exec::ignore_all_values();

CHECK(ex::sync_wait(std::move(sender)));
CHECK(sum == 6);
}

#if !STDEXEC_NO_STDCPP_EXCEPTIONS()
TEST_CASE("schedule_all on static_thread_pool sends errors from set_next",
"[types][static_thread_pool]")
Expand Down
Loading