Do not invoke bulk_chunked for zero shape - #2210
Merged
ericniebler merged 2 commits intoAug 17, 2026
Merged
Conversation
fallintoplace
force-pushed
the
fix/bulk-chunked-empty-shape
branch
from
August 16, 2026 13:24
4804e2e to
ffcb102
Compare
ericniebler
approved these changes
Aug 16, 2026
Collaborator
|
/ok to test ffcb102 |
Collaborator
|
/ok to test ef2bf69 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
bulk_chunkedcurrently calls the function once with(0, 0)when the shape is zero.exec.bulkrequires each chunk to satisfyb < e, so an empty shape has no valid chunk.shape <= 0.The exposition-only default implementation in the same section currently calls
f(0, shape, args...)unconditionally. That looks inconsistent with the non-empty chunk requirement. This change follows the behavioral requirement.Test
build/test/test.stdexec "[adaptors][bulk]"(363 assertions, 59 test cases)ctest --test-dir build --output-on-failure(953 passed)See exec.bulk.