Exclude tests involving adjoint solver from make check#3181
Open
oskooi wants to merge 3 commits intoNanoComp:masterfrom
Open
Exclude tests involving adjoint solver from make check#3181oskooi wants to merge 3 commits intoNanoComp:masterfrom
make check#3181oskooi wants to merge 3 commits intoNanoComp:masterfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #3181 +/- ##
===========================================
- Coverage 73.81% 63.65% -10.16%
===========================================
Files 18 18
Lines 5423 5454 +31
===========================================
- Hits 4003 3472 -531
- Misses 1420 1982 +562 🚀 New features to boost your workflow:
|
Collaborator
|
Is there a way to conditionally run this? And/or run it periodically or upon a trigger? |
Collaborator
|
Maybe add a workflow for a new action to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four tests involving the adjoint solver (particularly
test_adjoint_solver.py) take an unusually long time to complete which tends to slow down the CI. This PR modifiesmake checkto exclude these tests and instead creates amake check-adjointwhicn can be used to run all tests (including those involving the adjoint solver).