fix(runtime): resolve app entry from ApplicationPath in runMainApplication - #58
Closed
NathanWalker wants to merge 1 commit into
Closed
fix(runtime): resolve app entry from ApplicationPath in runMainApplication#58NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
…ation runMainApplication hardcoded ./app/index.js, which does not exist in CLI-built apps (they ship app/bundle.js with package.json main: "bundle"). Boot from the configured application directory instead, so the module resolver's existing directory handling picks the entry from package.json main and still falls back to index.* for plain layouts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runMainApplication hardcoded ./app/index.js, which does not exist in
CLI-built apps (they ship app/bundle.js with package.json main: "bundle").
Boot from the configured application directory instead, so the module
resolver's existing directory handling picks the entry from package.json
main and still falls back to index.* for plain layouts.
Found while bringing @nativescript/core up on the ios-quickjs runtime flavor. The seven fixes in this series were validated together on the iOS 26.5 simulator (combined branch:
fix/run-main-application-entry): a SolidJS + dominative app boots, renders, and runs stably with all of them applied. Each PR is independent and cherry-picked onto main.🤖 Generated with Claude Code