fix(ui): avoid mobile selection action overlap#622
Open
pascalandr wants to merge 1 commit into
Open
Conversation
Position CodeNomad selection actions below the final selected line on touch-only devices so Android's native text-selection toolbar can remain above the selection without covering app actions. Desktop and hybrid fine-pointer behavior retain the existing placement. Keep the actions inside the clipped message stream by falling back to its top edge when there is not enough room below. Add focused geometry coverage for normal touch placement, bottom-edge fallback, and unchanged desktop coordinates, and register the test in PR CI.
pascalandr
commented
Jul 22, 2026
pascalandr
left a comment
pascalandr
left a comment
Contributor
Author
There was a problem hiding this comment.
Gatekeeper review, round 1: 1 finding.
High: touch placement initially did not account for the clipped message stream's bottom edge, so a selection near the bottom could move the action popover off-screen. Fixed in this PR by falling back to the stream's top edge when the popover cannot fit below the selection, with a regression test for that geometry.
pascalandr
commented
Jul 22, 2026
pascalandr
left a comment
pascalandr
left a comment
Contributor
Author
There was a problem hiding this comment.
Gatekeeper review, round 2: zero findings.
Verified the demonstrated Android native-toolbar collision, unchanged desktop coordinates, touch bottom-edge visibility, focused regression coverage, and PR CI registration.
Contributor
Author
|
@shantur LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Closes #598