Support integer/slice indexing on compound datasets#124
Open
bendichter wants to merge 1 commit intomainfrom
Open
Support integer/slice indexing on compound datasets#124bendichter wants to merge 1 commit intomainfrom
bendichter wants to merge 1 commit intomainfrom
Conversation
Fixes #115. Previously, indexing a compound dataset with anything other than a field name string raised a TypeError. hdmf needs integer indexing (dataset[0]) to check if a 1-element compound dataset is scalar, which caused icephys files to fail when opened via lindi. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 81.63% 81.74% +0.11%
==========================================
Files 30 30
Lines 2793 2805 +12
==========================================
+ Hits 2280 2293 +13
+ Misses 513 512 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataset[0]), which raised aTypeError_get_compound_rowsmethod to handle integer indexing (returnsnp.void) and slice indexing (returns structured numpy array), with proper reference decodingTest plan
🤖 Generated with Claude Code