Add example of setting Units.resolution in the ecephys tutorial#2174
Open
h-mayorquin wants to merge 3 commits intodevfrom
Open
Add example of setting Units.resolution in the ecephys tutorial#2174h-mayorquin wants to merge 3 commits intodevfrom
h-mayorquin wants to merge 3 commits intodevfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2174 +/- ##
==========================================
- Coverage 95.10% 94.86% -0.24%
==========================================
Files 29 29
Lines 2943 2943
Branches 443 443
==========================================
- Hits 2799 2792 -7
- Misses 86 93 +7
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
At the inspector we are working on
check_units_resolution_is_setcheck (NeurodataWithoutBorders/nwbinspector#685), which flagsUnitstables that containspike_timesbut have noresolutionset. Users running the inspector on files created by following our tutorials would get this warning with no guidance on how to fix it.I have added a short section to the ecephys tutorial that sets
nwbfile.units.resolutionright after the existingadd_unitloop, with a brief explanation of what the field means and why it matters. I kept the change minimal to avoid restructuring the existing tutorial flow.What was the reasoning behind this change? Please explain the changes briefly.
Checklist
ruff check . && codespellfrom the source directory.