Conversation
Contributor
|
@namtnt could you please squash the commits? And the FIX/IMP commit msg should not has version prefix, so that we can pw-port down-port it w/o the need to update commit msg. |
cuongnmtm
suggested changes
Mar 4, 2026
| user_role_ids = fields.One2many( | ||
| comodel_name="res.users.role", | ||
| string="User Roles", | ||
| string="Roles", |
There was a problem hiding this comment.
I don't think we need to change this. Do you have a good reason for this?
Author
There was a problem hiding this comment.
We need this change to fix this warning WARNING odoo odoo.addons.base.models.ir_model: Two fields (user_role_ids, role_ids) of res.users() have the same label: User Roles. [Modules: base_user_role and mail]
namtnt
changed the title
cuongnmtm
approved these changes
Mar 4, 2026
…though the user has roles in form view
namtnt
force-pushed
the
19.0-fix_base_user_role
branch
from
b75e07b to
2a4cfeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, native Odoo already defines a
role_idsfield (m2m). This overrides therole_idsfield (o2m) from thebase_user_rolemodule, which causes the User Roles field to be empty in the User list view.Changes
Renamed
role_idsfield touser_role_ids.Reproduce:
Create a User and set a role for the User
Back to User list view -> User Roles is empty
