fix: call validate_import_csv_rows in parse_export_format#831
Open
PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
Open
fix: call validate_import_csv_rows in parse_export_format#831PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
Conversation
Contributor
Author
|
Hi @northdpole @Pa04rth Context: I previously worked on the CSV import validation path during MyOpenCRE ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a runtime regression in CSV import parsing.
parse_export_format()currently callsvalidate_export_csv_rows(...), but the validator defined inspreadsheet_parsers.pyisvalidate_import_csv_rows(...).This causes:
NameError: name 'validate_export_csv_rows' is not definedContext
This validation flow was already introduced during the MyOpenCRE work, where CSV import validation logic was moved into
spreadsheet_parsers.pyviavalidate_import_csv_rows(see discussion in#584comment and related work in#682/#683).This PR is a focused follow-up to restore that intended path on latest
main.Change
application/utils/spreadsheet_parsers.py:validate_export_csv_rows(lfile)->validate_import_csv_rows(lfile)Validation
./venv/bin/python -m pytest application/tests/spreadsheet_parsers_test.py -q2 passedScope