Skip to content

Auto-approve generated docs sync PRs - #3411

Merged
rosslovas merged 1 commit into
mainfrom
ross/auto-approve-docs-sync
Aug 21, 2026
Merged

Auto-approve generated docs sync PRs#3411
rosslovas merged 1 commit into
mainfrom
ross/auto-approve-docs-sync

Conversation

@rosslovas

Copy link
Copy Markdown
Contributor

Summary

We want automatically generated PRs like #3410 to merge automatically so long as the build passes. For this they need to be approved, so this PR will automatically approve them as the github-actions bot (which, importantly, is a different user to the author of the PR and thus satisfies the review required check).

Risk

Automatically approving naturally always carries a risk of incorrectly approving a malicious PR; please sanity check that the workflow contains no holes in this regard!

@rosslovas
rosslovas marked this pull request as ready for review August 21, 2026 02:12

@borland borland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checks in the if statement are many, and specific. This looks pretty lock-tight to me. Approved

@team-marketing-branch-protections

Copy link
Copy Markdown

Pull request environment is available at https://stoctodocspr3411.z22.web.core.windows.net.

You can view the ephemeral environment status in Octopus Deploy.

This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity.

@rosslovas
rosslovas merged commit ab7a12b into main Aug 21, 2026
8 checks passed
@rosslovas
rosslovas deleted the ross/auto-approve-docs-sync branch August 21, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants